Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-253-accumulo@git.apache.org>
In-Reply-To: <git-pr-253-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #253: ACCUMULO-4086 Improve volume chooser fallback
Content-Type: text/plain
Message-Id: <20170727215828.8B8D6DFF9F@git1-us-west.apache.org>
Date: Thu, 27 Jul 2017 21:58:28 +0000 (UTC)
archived-at: Thu, 27 Jul 2017 21:58:32 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/253#discussion_r129969952
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/fs/VolumeChooser.java ---
    @@ -28,5 +29,5 @@
      * benefit from using per-table configuration using {@link Property#TABLE_ARBITRARY_PROP_PREFIX}.
      */
     public interface VolumeChooser {
    -  String choose(VolumeChooserEnvironment env, String[] options);
    +  String choose(VolumeChooserEnvironment env, String[] options) throws AccumuloException;
    --- End diff --
    
    AccumuloException is really a client-side exception, and probably shouldn't be used internally on the server-side.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---