Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 4A282200CD1 for ; Wed, 26 Jul 2017 19:22:19 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 48C0B1693A8; Wed, 26 Jul 2017 17:22:19 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 86B231693A1 for ; Wed, 26 Jul 2017 19:22:18 +0200 (CEST) Received: (qmail 5842 invoked by uid 500); 26 Jul 2017 17:22:17 -0000 Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@accumulo.apache.org Delivered-To: mailing list dev@accumulo.apache.org Received: (qmail 5824 invoked by uid 99); 26 Jul 2017 17:22:17 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2017 17:22:17 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 4ADF1E02FE; Wed, 26 Jul 2017 17:22:17 +0000 (UTC) From: joshelser To: dev@accumulo.apache.org Reply-To: dev@accumulo.apache.org References: In-Reply-To: Subject: [GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn... Content-Type: text/plain Message-Id: <20170726172217.4ADF1E02FE@git1-us-west.apache.org> Date: Wed, 26 Jul 2017 17:22:17 +0000 (UTC) archived-at: Wed, 26 Jul 2017 17:22:19 -0000 Github user joshelser commented on a diff in the pull request: https://github.com/apache/accumulo/pull/283#discussion_r129639323 --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java --- @@ -95,18 +92,7 @@ public int read(final byte[] b, final int off, int len) throws IOException { throw new IOException("Stream closed"); } in.seek(pos); - try { - ret = AccessController.doPrivileged(new PrivilegedExceptionAction() { --- End diff -- Oh, no no no, that's not what I meant. I only meant that I didn't recall seeing you make that change. It happening at the hackathon simply explains why I missed it. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---