Return-Path: <dev-return-19133-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 37167200CD1
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Wed, 26 Jul 2017 18:56:56 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 35BBC16295A; Wed, 26 Jul 2017 16:56:56 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id AB51A16257D
	for <archive-asf-public@cust-asf.ponee.io>; Wed, 26 Jul 2017 18:56:55 +0200 (CEST)
Received: (qmail 31251 invoked by uid 500); 26 Jul 2017 16:56:54 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 31208 invoked by uid 99); 26 Jul 2017 16:56:54 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Jul 2017 16:56:54 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id C0C34F3239; Wed, 26 Jul 2017 16:56:52 +0000 (UTC)
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-283-accumulo@git.apache.org>
In-Reply-To: <git-pr-283-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...
Content-Type: text/plain
Message-Id: <20170726165652.C0C34F3239@git1-us-west.apache.org>
Date: Wed, 26 Jul 2017 16:56:52 +0000 (UTC)
archived-at: Wed, 26 Jul 2017 16:56:56 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/283#discussion_r129629434
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java ---
    @@ -95,18 +92,7 @@ public int read(final byte[] b, final int off, int len) throws IOException {
             throw new IOException("Stream closed");
           }
           in.seek(pos);
    -      try {
    -        ret = AccessController.doPrivileged(new PrivilegedExceptionAction<Integer>() {
    --- End diff --
    
    I removed this in master branch with ACCUMULO-4498, and think it's safe to remove, but also think it could cause confusion for anybody who might have worked out a custom security policy for their environment. I think that's probably extremely low risk, though. I think it's fine to remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---