Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-275-accumulo@git.apache.org>
In-Reply-To: <git-pr-275-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...
Content-Type: text/plain
Message-Id: <20170719224409.6BF84DFC28@git1-us-west.apache.org>
Date: Wed, 19 Jul 2017 22:44:09 +0000 (UTC)
archived-at: Wed, 19 Jul 2017 22:44:11 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/275#discussion_r128386989
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java ---
    @@ -16,23 +16,28 @@
      */
     package org.apache.accumulo.core.iterators.system;
     
    +import com.google.common.collect.ImmutableSet;
    --- End diff --
    
    Oh, oops. I thought we had one, but I could see it just being eclipse's default. At least one other project I'm a part of uses https://google.github.io/styleguide/javaguide.html#s3.3-import-statements which I've grown to like.
    
    Anyways, this is becoming quite the tangent. Thanks for changing it back, Ivan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---