Return-Path: <dev-return-19055-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 11A7B200CC9
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon, 17 Jul 2017 21:10:41 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 2D7F2163381; Mon, 17 Jul 2017 19:10:35 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 9E92D1609E0
	for <archive-asf-public@cust-asf.ponee.io>; Mon, 17 Jul 2017 21:10:34 +0200 (CEST)
Received: (qmail 72765 invoked by uid 500); 17 Jul 2017 19:10:33 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 72746 invoked by uid 99); 17 Jul 2017 19:10:33 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 17 Jul 2017 19:10:33 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id 6B7E7E8E6B; Mon, 17 Jul 2017 19:10:33 +0000 (UTC)
From: ivakegg <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-275-accumulo@git.apache.org>
In-Reply-To: <git-pr-275-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...
Content-Type: text/plain
Message-Id: <20170717191033.6B7E7E8E6B@git1-us-west.apache.org>
Date: Mon, 17 Jul 2017 19:10:33 +0000 (UTC)
archived-at: Mon, 17 Jul 2017 19:10:41 -0000

Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/275#discussion_r127797510
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/util/LocalityGroupUtil.java ---
    @@ -50,16 +52,16 @@
     
       // private static final Logger log = Logger.getLogger(ColumnFamilySet.class);
     
    -  public static final Set<ByteSequence> EMPTY_CF_SET = Collections.emptySet();
    +  public static final Set<ByteSequence> EMPTY_CF_SET = ImmutableSet.of();
     
       public static Set<ByteSequence> families(Collection<Column> columns) {
         if (columns.size() == 0)
           return EMPTY_CF_SET;
    -    Set<ByteSequence> result = new HashSet<>(columns.size());
    +    Builder<ByteSequence> builder = ImmutableSet.builder();
         for (Column col : columns) {
    -      result.add(new ArrayByteSequence(col.getColumnFamily()));
    +      builder.add(new ArrayByteSequence(col.getColumnFamily()));
         }
    -    return result;
    +    return builder.build();
    --- End diff --
    
    I will look into that, although I am hoping that this can be backported to 1.8.2 as well.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---