Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: ctubbsii <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-279-accumulo@git.apache.org>
In-Reply-To: <git-pr-279-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Content-Type: text/plain
Message-Id: <20170710200133.18BFDDFF9F@git1-us-west.apache.org>
Date: Mon, 10 Jul 2017 20:01:33 +0000 (UTC)
archived-at: Mon, 10 Jul 2017 20:01:36 -0000

Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126501018
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ---
    @@ -0,0 +1,86 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import static java.nio.charset.StandardCharsets.UTF_8;
    +import static java.util.Objects.requireNonNull;
    +
    +import java.io.Serializable;
    +import java.util.Objects;
    +
    +/**
    + * An abstract identifier class for comparing equality of identifiers of the same type.
    + */
    +public abstract class AbstractId implements Comparable<AbstractId>, Serializable {
    +
    +  private static final long serialVersionUID = -155513612834787244L;
    +  private final String canonical;
    +  private Integer hashCode = null;
    +
    +  protected AbstractId(final String canonical) {
    +    requireNonNull(canonical, "canonical cannot be null");
    +    this.canonical = canonical;
    +  }
    +
    +  /**
    +   * The canonical ID
    +   */
    +  public final String canonicalID() {
    +    return canonical;
    +  }
    +
    +  public boolean isEmpty() {
    +    return canonical.isEmpty();
    +  }
    +
    +  /**
    +   * AbstractID objects are considered equal if, and only if, they are of the same type and have the same canonical identifier.
    +   */
    +  @Override
    +  public boolean equals(final Object obj) {
    +    return obj != null && Objects.equals(getClass(), obj.getClass()) && Objects.equals(canonicalID(), ((AbstractId) obj).canonicalID());
    +  }
    +
    +  @Override
    +  public int hashCode() {
    +    if (hashCode == null) {
    +      hashCode = Objects.hash(canonicalID());
    +    }
    +    return hashCode;
    +  }
    +
    +  /**
    +   * Returns a string of the canonical ID
    +   */
    +  @Override
    +  public String toString() {
    +    return canonical;
    +  }
    +
    +  /**
    +   * Return a UTF_8 byte[] of the canonical ID.
    +   */
    +  public final byte[] getUtf8Bytes() {
    +    return canonical.getBytes(UTF_8);
    +  }
    +
    +  public int compareTo(AbstractId id) {
    --- End diff --
    
    Missing Override annotation?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---