accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo issue #286: ACCUMULO-4689 Do not set empty SSL store types
Date Mon, 31 Jul 2017 22:10:54 GMT
Github user joshelser commented on the issue:
    > >    there is no obligation of review before commit.
    > Right, that's why I was wondering why you bothered with the PR.
    Personal preference. If someone wants to make time to review my code, I like to go out
of my way to make it easier for them to do so. The level of confidence I have in a change
determines on how long I'll wait for that. If it's truly trivial I won't (in this case specifically,
there were two ways to implement it that were essentially the same thing. The irony is that
the other implementation is actually what Billie had done previously)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message