accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...
Date Wed, 26 Jul 2017 17:07:48 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/283#discussion_r129635623
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/BasicServlet.java
---
    @@ -264,4 +264,12 @@ protected static void banner(StringBuilder sb, String klass, String
text) {
         sb.append("<br />\n<h2 class='").append(klass).append("'>").append(text).append("</h2>\n");
       }
     
    +  /**
    +   * Creates a {@link Cookie} with the given name and value, also setting the HttpOnly
attribute on the cookie.
    +   */
    +  protected static Cookie createCookie(String name, String value) {
    +    Cookie c = new Cookie(name, value);
    +    c.setHttpOnly(true);
    --- End diff --
    
    > Are we certain we're not manipulating them in client-side javascript now? If we are,
this will break that.
    
    I can double-check, but I'm not aware of that in 1.x. Not sure how the table sorting stuff
works. It would be nice to quell these warnings in the future, but I may begrudgingly have
to revert.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message