accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...
Date Wed, 26 Jul 2017 16:56:52 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/283#discussion_r129629434
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
    @@ -95,18 +92,7 @@ public int read(final byte[] b, final int off, int len) throws IOException
{
             throw new IOException("Stream closed");
           }
           in.seek(pos);
    -      try {
    -        ret = AccessController.doPrivileged(new PrivilegedExceptionAction<Integer>()
{
    --- End diff --
    
    I removed this in master branch with ACCUMULO-4498, and think it's safe to remove, but
also think it could cause confusion for anybody who might have worked out a custom security
policy for their environment. I think that's probably extremely low risk, though. I think
it's fine to remove.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message