accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #283: ACCUMULO-4687 Clean up some static-analysis warn...
Date Wed, 26 Jul 2017 16:01:42 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/283#discussion_r129616922
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/BoundedRangeFileInputStream.java
---
    @@ -95,18 +92,7 @@ public int read(final byte[] b, final int off, int len) throws IOException
{
             throw new IOException("Stream closed");
           }
           in.seek(pos);
    -      try {
    -        ret = AccessController.doPrivileged(new PrivilegedExceptionAction<Integer>()
{
    --- End diff --
    
    This is the one change which I'm not quite sure about.
    
    It having been there since the dawn of time and without comment, I'm really not sure what
it was intended to do. This predates all of the Kerberos work -- the only thing I can think
of would have been the old SecurityManager constraints (but, if memory serves, those were
more around SKVI's, not reading data from HDFS).
    
    @billierinaldi, @keith-turner, @ericnewton, @scubafuchs: any guesses? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message