accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...
Date Wed, 19 Jul 2017 22:44:09 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/275#discussion_r128386989
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java
---
    @@ -16,23 +16,28 @@
      */
     package org.apache.accumulo.core.iterators.system;
     
    +import com.google.common.collect.ImmutableSet;
    --- End diff --
    
    Oh, oops. I thought we had one, but I could see it just being eclipse's default. At least
one other project I'm a part of uses https://google.github.io/styleguide/javaguide.html#s3.3-import-statements
which I've grown to like.
    
    Anyways, this is becoming quite the tangent. Thanks for changing it back, Ivan.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message