accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Wed, 12 Jul 2017 20:51:01 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r127068208
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
---
    @@ -70,15 +70,15 @@
     
     public abstract class GroupBalancer extends TabletBalancer {
     
    -  private final String tableId;
    +  private final Table.ID tableId;
       private long lastRun = 0;
     
       /**
        * @return A function that groups tablets into named groups.
        */
       protected abstract Function<KeyExtent,String> getPartitioner();
     
    -  public GroupBalancer(String tableId) {
    +  public GroupBalancer(Table.ID tableId) {
    --- End diff --
    
    Backed out changes from GroupBalancer and RegexGroupBalancer in ef30550



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message