accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Wed, 12 Jul 2017 20:11:08 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r127058627
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java ---
    @@ -0,0 +1,42 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import org.apache.accumulo.core.client.Instance;
    +
    +public class Namespace {
    --- End diff --
    
    > I'm reticent to include structure on the promise of "code getting finished"
    
    With Accumulo being such a complex and mature project, I think incremental code changes
should be encouraged.  It is very difficult to make significant code changes all at once.
 
    
    > this just seems like a layer of indirection that causes more typing
    
    If useful code can be commited, while at the same time creating opportunity to assist
in future significant development, I think it is definitely worth typing the extra "."
    
    Should I add comments to the javadoc explaining how the class is also a placeholder for
future work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message