accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mikewalch <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Tue, 11 Jul 2017 18:00:47 GMT
Github user mikewalch commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126764150
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/AbstractId.java ---
    @@ -0,0 +1,86 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import static java.nio.charset.StandardCharsets.UTF_8;
    +import static java.util.Objects.requireNonNull;
    +
    +import java.io.Serializable;
    +import java.util.Objects;
    +
    +/**
    + * An abstract identifier class for comparing equality of identifiers of the same type.
    + */
    +public abstract class AbstractId implements Comparable<AbstractId>, Serializable
{
    +
    +  private static final long serialVersionUID = -155513612834787244L;
    +  private final String canonical;
    +  private Integer hashCode = null;
    +
    +  protected AbstractId(final String canonical) {
    --- End diff --
    
    Could add a comment then to make it clear.  I didn't know what was expected given that
variable name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message