accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Tue, 11 Jul 2017 17:34:42 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126757396
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespace.java ---
    @@ -0,0 +1,42 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import org.apache.accumulo.core.client.Instance;
    +
    +public class Namespace {
    --- End diff --
    
    @milleruntime took based this implementation on my [ACCUMULO-2589] branch, as I had suggested
in the comments of this JIRA issue ([ACCUMULO-3238]). The longer term goal with my branch
was to make `Table` and `Namespace` first class citizens in the public API. The ID would be
just one facet of those API classes. At this point, it doesn't matter, because they are being
used only for internal code. However, I do think it'd be easier for follow-on work to keep
the inner-class, in case more public-facing features are adapted from my branch later.
    
    [ACCUMULO-2589]: https://issues.apache.org/jira/browse/ACCUMULO-2589
    [ACCUMULO-3238]: https://issues.apache.org/jira/browse/ACCUMULO-3238


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message