accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Tue, 11 Jul 2017 16:49:09 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126746152
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/TableOfflineException.java
---
    @@ -26,7 +27,7 @@ private static String getTableName(Instance instance, String tableId)
{
         if (tableId == null)
           return " <unknown table> ";
         try {
    -      String tableName = Tables.getTableName(instance, tableId);
    +      String tableName = Tables.getTableName(instance, new Table.ID(tableId));
    --- End diff --
    
    > I think we should keep anything we do in this regard out of the public API
    
    Yes, took me a moment to realize that this wasn't actually public facing. Still applies
when viewed in a "it's a nice API to use"
    
    > I imagine there was a good reason, but I don't have insight into the history of that
part of KeyExtent and there don't appear to be any comments explaining why it was needed.
    
    I know it was/is a big problem for them. Seeing the prevalence of this change, I assume
it would also be non-trivial for us..


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message