accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Tue, 11 Jul 2017 16:15:28 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126737922
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/TableOfflineException.java
---
    @@ -26,7 +27,7 @@ private static String getTableName(Instance instance, String tableId)
{
         if (tableId == null)
           return " <unknown table> ";
         try {
    -      String tableName = Tables.getTableName(instance, tableId);
    +      String tableName = Tables.getTableName(instance, new Table.ID(tableId));
    --- End diff --
    
    HBase does this with their `TableName` class to avoid tons of objects hanging around needing
GC. The API is pretty nice as an end-user:
    
    ```java
    Connection conn = ...;
    Table t = conn.getTable(TableName.valueOf("josh_table1"));
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message