accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Mon, 10 Jul 2017 20:43:52 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126531488
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Namespaces.java ---
    @@ -72,10 +78,10 @@ public String invalidMessage(String namespace) {
         }
       };
     
    -  public static final String DEFAULT_NAMESPACE_ID = "+default";
    -  public static final String DEFAULT_NAMESPACE = "";
    -  public static final String ACCUMULO_NAMESPACE_ID = "+accumulo";
    -  public static final String ACCUMULO_NAMESPACE = "accumulo";
    +  public static final Namespace.ID DEFAULT_NAMESPACE_ID = Namespace.ID.DEFAULT;
    +  public static final String DEFAULT_NAMESPACE = Namespace.DEFAULT;
    +  public static final Namespace.ID ACCUMULO_NAMESPACE_ID = Namespace.ID.ACCUMULO;
    +  public static final String ACCUMULO_NAMESPACE = Namespace.ACCUMULO;
    --- End diff --
    
    Agreed.  This was an attempt to minimize number of changes in one PR.  Assuming there
aren't any showstoppers with these changes, I will create follow on ticket.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message