accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Mon, 10 Jul 2017 20:01:57 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126511167
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/balancer/GroupBalancer.java
---
    @@ -70,15 +70,15 @@
     
     public abstract class GroupBalancer extends TabletBalancer {
     
    -  private final String tableId;
    +  private final Table.ID tableId;
       private long lastRun = 0;
     
       /**
        * @return A function that groups tablets into named groups.
        */
       protected abstract Function<KeyExtent,String> getPartitioner();
     
    -  public GroupBalancer(String tableId) {
    +  public GroupBalancer(Table.ID tableId) {
    --- End diff --
    
    This isn't strictly public API, but the balancer is one of those internal "points of code
injection", for users to change Accumulo's default behavior. If API change can be avoided,
that is preferred here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message