accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Mon, 10 Jul 2017 20:01:57 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126509016
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/client/impl/Table.java ---
    @@ -0,0 +1,48 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.client.impl;
    +
    +import org.apache.accumulo.core.client.Instance;
    +import org.apache.hadoop.io.Text;
    +
    +public class Table {
    +
    +  /**
    +   * Object representing an internal table ID. This class was created to help with type
safety. For help obtaining the value of a table ID from Zookeeper, see
    +   * {@link Tables#getTableId(Instance, String)}
    +   */
    +  public static class ID extends AbstractId {
    +    private static final long serialVersionUID = 7399913185860577809L;
    +
    +    public static final ID METADATA = new ID("!0");
    +    public static final ID REPLICATION = new ID("+rep");
    +    public static final ID ROOT = new ID("+r");
    +
    +    public static ID empty() {
    +      return new ID("");
    +    }
    +
    +    public ID(final String canonical) {
    +      super(canonical);
    +    }
    +
    +    public ID(Text textID) {
    +      super(textID.toString());
    +    }
    +  }
    +
    --- End diff --
    
    Noticed you had constants for namespace "ACCUMULO" and "DEFAULT" names, but no constants
here for built-in table names. Not strictly necessary, but would be nice to be consistent.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message