accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ctubbsii <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Mon, 10 Jul 2017 20:01:57 GMT
Github user ctubbsii commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126509804
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/data/impl/TabletIdImpl.java ---
    @@ -36,7 +36,7 @@ public int compareTo(TabletId o) {
     
       @Override
       public Text getTableId() {
    -    return new Text(ke.getTableId());
    +    return new Text(ke.getTableId().getUtf8Bytes());
    --- End diff --
    
    Could also rely on the string constructor for Text here. It should use UTF8 bytes internally.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message