accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From milleruntime <...@git.apache.org>
Subject [GitHub] accumulo pull request #279: ACCUMULO-3238 Table.ID Namespace.ID Refactor
Date Mon, 10 Jul 2017 18:48:28 GMT
Github user milleruntime commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/279#discussion_r126505403
  
    --- Diff: server/master/src/main/java/org/apache/accumulo/master/tableOps/WriteExportFiles.java
---
    @@ -144,16 +145,15 @@ public static void exportTable(VolumeManager fs, AccumuloServerContext
context,
         BufferedOutputStream bufOut = new BufferedOutputStream(zipOut);
         DataOutputStream dataOut = new DataOutputStream(bufOut);
     
    -    try {
    +    try (OutputStreamWriter osw = new OutputStreamWriter(dataOut, UTF_8)) {
    --- End diff --
    
    This got dinged by Findbugs for not closing the stream so I had put the OutputStreamWriter
in the try with resources.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message