Return-Path: <dev-return-18926-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id 88875200CB7
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Fri, 30 Jun 2017 17:53:10 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id 85211160C00; Fri, 30 Jun 2017 15:53:10 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id C90AC160BDD
	for <archive-asf-public@cust-asf.ponee.io>; Fri, 30 Jun 2017 17:53:09 +0200 (CEST)
Received: (qmail 80653 invoked by uid 500); 30 Jun 2017 15:53:09 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 80640 invoked by uid 99); 30 Jun 2017 15:53:08 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 30 Jun 2017 15:53:08 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id A2339DFE22; Fri, 30 Jun 2017 15:53:08 +0000 (UTC)
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-275-accumulo@git.apache.org>
In-Reply-To: <git-pr-275-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...
Content-Type: text/plain
Message-Id: <20170630155308.A2339DFE22@git1-us-west.apache.org>
Date: Fri, 30 Jun 2017 15:53:08 +0000 (UTC)
archived-at: Fri, 30 Jun 2017 15:53:10 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/275#discussion_r125072047
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java ---
    @@ -97,75 +133,117 @@ public static final int seek(HeapIterator hiter, LocalityGroup[] groups, Set<Byt
         else
           cfSet = Collections.emptySet();
     
    -    for (LocalityGroup lgr : groups) {
    -      // when include is set to true it means this locality groups contains
    -      // wanted column families
    -      boolean include = false;
    +    // determine the set of groups to use
    +    Set<LocalityGroup> groupsToUse = new HashSet<LocalityGroup>();
     
    -      if (cfSet.size() == 0) {
    -        include = !inclusive;
    -      } else if (lgr.isDefaultLocalityGroup && lgr.columnFamilies == null) {
    -        // do not know what column families are in the default locality group,
    -        // only know what column families are not in it
    +    // if no column families specified, then include all groups unless !inclusive
    +    if (cfSet.size() == 0) {
    +      if (!inclusive) {
    +        groupsToUse.addAll(Arrays.asList(groups.groups));
    --- End diff --
    
    For this case we could have an immutable set that is always used.  Create this once in `LocalityGroupContext`.  Then we can avoid allocating the `HashSet` for `groupsToUse`, just allocate it in the else.  We can also avoid populating the hashset.  Could use Guava immutable set


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---