Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-271-accumulo@git.apache.org>
In-Reply-To: <git-pr-271-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #271: ACCUMULO-4655 Added a Response Time column to th...
Content-Type: text/plain
Message-Id: <20170620161944.C032ADFA6C@git1-us-west.apache.org>
Date: Tue, 20 Jun 2017 16:19:44 +0000 (UTC)
archived-at: Tue, 20 Jun 2017 16:19:48 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/271#discussion_r123024693
  
    --- Diff: server/monitor/src/main/java/org/apache/accumulo/monitor/servlets/TServersServlet.java ---
    @@ -314,13 +314,22 @@ static void doTserverList(HttpServletRequest req, StringBuilder sb, List<TabletS
         long now = System.currentTimeMillis();
     
         double avgLastContact = 0.;
    +    double avgResponseTime = 0.;
    +    int count = 0;
         for (TabletServerStatus status : tservers) {
    +      count++;
           avgLastContact += (now - status.lastContact);
    +      avgResponseTime += status.responseTime;
    --- End diff --
    
    Did you give any thought to including other statistics than just avg? I am thinking about the case where there are one or a few outliers which significantly skew the mean. p95/p99 are nice to give some context, but admittedly require a little more work to compute.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---