Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-270-accumulo@git.apache.org>
In-Reply-To: <git-pr-270-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #270: ACCUMULO-4657 Reduce excessive logging / logging...
Content-Type: text/plain
Message-Id: <20170620122838.8328DDFA83@git1-us-west.apache.org>
Date: Tue, 20 Jun 2017 12:28:38 +0000 (UTC)
archived-at: Tue, 20 Jun 2017 12:28:40 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/270#discussion_r122960232
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/util/MetadataTableUtil.java ---
    @@ -894,12 +895,19 @@ public static void removeBulkLoadEntries(Connector conn, String tableId, long ti
             BatchWriter bw = conn.createBatchWriter(MetadataTable.NAME, new BatchWriterConfig())) {
           mscanner.setRange(new KeyExtent(tableId, null, null).toMetadataRange());
           mscanner.fetchColumnFamily(TabletsSection.BulkFileColumnFamily.NAME);
    +      boolean shouldTrace = log.isTraceEnabled();
    +      byte[] tidAsBytes = Long.toString(tid).getBytes();
    --- End diff --
    
    For predictability in different environments, should call `getBytes(StandardCharsets.UTF_8)`.  Value's toString method did something like this in the prev code.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---