Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-265-accumulo@git.apache.org>
In-Reply-To: <git-pr-265-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #265: ACCUMULO-4647 - start of contributor guide
Content-Type: text/plain
Message-Id: <20170606153526.B2BE5DFF2D@git1-us-west.apache.org>
Date: Tue,  6 Jun 2017 15:35:26 +0000 (UTC)
archived-at: Tue, 06 Jun 2017 15:35:30 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/265#discussion_r120396006
  
    --- Diff: CONTRIBUTING.md ---
    @@ -0,0 +1,43 @@
    +<!--
    +Licensed to the Apache Software Foundation (ASF) under one or more
    +contributor license agreements.  See the NOTICE file distributed with
    +this work for additional information regarding copyright ownership.
    +The ASF licenses this file to You under the Apache License, Version 2.0
    +(the "License"); you may not use this file except in compliance with
    +the License.  You may obtain a copy of the License at
    +
    +    http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing, software
    +distributed under the License is distributed on an "AS IS" BASIS,
    +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +See the License for the specific language governing permissions and
    +limitations under the License.
    +-->
    +
    +# Contributors Guide
    +
    + If you believe that you have found a bug, please search for an existing [issue](https://issues.apache.org/jira/browse/accumulo) to see if it has already been reported. If you would like to add a new feature to Accumulo, please send an email with your idea to the [dev](mailto:dev@accumulo.apache.org) mail list. If it's appropriate, then we will create a ticket and assign it to you.
    +
    +## Development
    +
    +- See the [Developer's Guide](https://accumulo.apache.org/contributor/source) for information regarding common build commands, IDE setup and more.
    +- Ensure that your work targets the correct branch
    +- Add / update unit and integration tests
    +
    +## Patch Submission
    +
    +- Ensure that Accumulo builds cleanly before submiting your patch using the command: `mvn clean verify`
    +- Before submission please squash your commits using a message that starts with the JIRA issue number and a description of the changes.
    +- Patches should be submitted in the form of Pull Requests to the Apache Accumulo GitHub [repository](https://github.com/apache/accumulo/) or to the [Review Board](https://reviews.apache.org) accumulo repository.
    +
    +## Review
    +
    +- While everyone is welcome to review patches, at least one committer needs to review and approve your patch.
    --- End diff --
    
    Oh, the last sentence I suggested I think makes things more clearly `Any commiter can approve and merge a PR.`.
    
    I think we should write this guide such that it clearly implies CTR, as that is the current agreed upon way of working.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---