Return-Path: <dev-return-18656-archive-asf-public=cust-asf.ponee.io@accumulo.apache.org>
X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io
Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io
Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183])
	by cust-asf2.ponee.io (Postfix) with ESMTP id DB398200CAC
	for <archive-asf-public-internal@cust-asf2.ponee.io>; Mon,  5 Jun 2017 01:13:30 +0200 (CEST)
Received: by cust-asf.ponee.io (Postfix)
	id D9E82160BE3; Sun,  4 Jun 2017 23:13:30 +0000 (UTC)
Delivered-To: archive-asf-public@cust-asf.ponee.io
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by cust-asf.ponee.io (Postfix) with SMTP id 2C54F160BE0
	for <archive-asf-public@cust-asf.ponee.io>; Mon,  5 Jun 2017 01:13:30 +0200 (CEST)
Received: (qmail 58742 invoked by uid 500); 4 Jun 2017 23:13:29 -0000
Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@accumulo.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@accumulo.apache.org>
List-Post: <mailto:dev@accumulo.apache.org>
List-Id: <dev.accumulo.apache.org>
Reply-To: dev@accumulo.apache.org
Delivered-To: mailing list dev@accumulo.apache.org
Received: (qmail 58731 invoked by uid 99); 4 Jun 2017 23:13:29 -0000
Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23)
    by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 04 Jun 2017 23:13:29 +0000
Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33)
	id EBCF6DFBC6; Sun,  4 Jun 2017 23:13:28 +0000 (UTC)
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-260-accumulo@git.apache.org>
In-Reply-To: <git-pr-260-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Content-Type: text/plain
Message-Id: <20170604231328.EBCF6DFBC6@git1-us-west.apache.org>
Date: Sun,  4 Jun 2017 23:13:28 +0000 (UTC)
archived-at: Sun, 04 Jun 2017 23:13:31 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r120023595
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/YieldCallback.java ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.iterators;
    +
    +/**
    + * This callback handles the state of yielding within an iterator
    + */
    +public class YieldCallback<K> {
    +  private K key;
    +
    +  /**
    +   * Called by the iterator when a next or seek call yields control.
    +   *
    +   * @param key
    +   *          the key position at which the iterator yielded.
    +   */
    +  public void yield(K key) {
    +    this.key = key;
    +  }
    +
    +  /**
    +   * Called by the client to see if the iterator yielded
    +   *
    +   * @return true if iterator yielded control
    +   */
    +  public boolean hasYielded() {
    +    return (this.key != null);
    --- End diff --
    
    Dry humor often falls flat online, especially when dealing with criticism. Thanks for clarifying. No need to buy any beers.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---