accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #275: ACCUMULO-4667 Reworked the LocalityGroupIterator...
Date Fri, 30 Jun 2017 15:53:08 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/275#discussion_r125072047
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/LocalityGroupIterator.java
---
    @@ -97,75 +133,117 @@ public static final int seek(HeapIterator hiter, LocalityGroup[]
groups, Set<Byt
         else
           cfSet = Collections.emptySet();
     
    -    for (LocalityGroup lgr : groups) {
    -      // when include is set to true it means this locality groups contains
    -      // wanted column families
    -      boolean include = false;
    +    // determine the set of groups to use
    +    Set<LocalityGroup> groupsToUse = new HashSet<LocalityGroup>();
     
    -      if (cfSet.size() == 0) {
    -        include = !inclusive;
    -      } else if (lgr.isDefaultLocalityGroup && lgr.columnFamilies == null) {
    -        // do not know what column families are in the default locality group,
    -        // only know what column families are not in it
    +    // if no column families specified, then include all groups unless !inclusive
    +    if (cfSet.size() == 0) {
    +      if (!inclusive) {
    +        groupsToUse.addAll(Arrays.asList(groups.groups));
    --- End diff --
    
    For this case we could have an immutable set that is always used.  Create this once in
`LocalityGroupContext`.  Then we can avoid allocating the `HashSet` for `groupsToUse`, just
allocate it in the else.  We can also avoid populating the hashset.  Could use Guava immutable
set


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message