accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #271: ACCUMULO-4655 Added a Response Time column to th...
Date Tue, 20 Jun 2017 18:23:15 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/271#discussion_r123056495
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/LiveTServerSet.java
---
    @@ -120,11 +120,17 @@ public TabletServerStatus getTableMap(boolean usePooledConnection)
throws TExcep
           if (usePooledConnection == true)
             throw new UnsupportedOperationException();
     
    +      long start = System.currentTimeMillis();
    --- End diff --
    
    I've started preferring to use nanoTime() for small, single-threaded timings. I know that's
the sort of thing that it's meant to do well (local timings), but I'm not sure if there's
a downside to it. Just thought I'd mention it. Like you say, at the end of the day, it probably
won't matter.
    
    I think @keith-turner had originally turned me onto it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message