accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #272: ACCUMULO-4654 Added the ability to continue bala...
Date Tue, 20 Jun 2017 16:28:18 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/272#discussion_r123027005
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
---
    @@ -367,8 +396,30 @@ public long balance(SortedMap<TServerInstance,TabletServerStatus>
current, Set<K
         }
     
         if (migrations != null && migrations.size() > 0) {
    -      LOG.warn("Not balancing tables due to {} outstanding migrations", migrations.size());
    -      return minBalanceTime;
    +      if (migrations.size() >= maxOutstandingMigrations) {
    +        LOG.warn("Not balancing tables due to {} outstanding migrations", migrations.size());
    +        LOG.trace("Sample up to 10 outstanding migrations: {}", Iterables.limit(migrations,
10));
    +        return minBalanceTime;
    +      }
    +
    +      LOG.debug("Current outstanding migrations of " + migrations.size() + " being applied");
    +      LOG.trace("Sample up to 10 outstanding migrations: {}", Iterables.limit(migrations,
10));
    --- End diff --
    
    Same here.
    
    Also, forgot to use the `{}` syntax on the debug above.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message