accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request #272: ACCUMULO-4654 Added the ability to continue bala...
Date Tue, 20 Jun 2017 16:08:45 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/272#discussion_r123022077
  
    --- Diff: server/base/src/main/java/org/apache/accumulo/server/master/balancer/HostRegexTableLoadBalancer.java
---
    @@ -81,15 +86,24 @@
           + "balancer.host.regex.concurrent.migrations";
       private static final int HOST_BALANCER_REGEX_MAX_MIGRATIONS_DEFAULT = 250;
       protected static final String DEFAULT_POOL = "HostTableLoadBalancer.ALL";
    +  private static final int DEFAULT_OUTSTANDING_MIGRATIONS = 500;
    +  public static final String HOST_BALANCER_OUTSTANDING_MIGRATIONS_KEY = Property.TABLE_ARBITRARY_PROP_PREFIX.getKey()
    +      + "balancer.host.regex.max.outstanding.migrations";
     
       protected long oobCheckMillis = AccumuloConfiguration.getTimeInMillis(HOST_BALANCER_OOB_DEFAULT);
     
    +  private static final long ONE_HOUR = 60 * 60 * 1000;
    +  private static final Set<KeyExtent> EMPTY_MIGRATIONS = Collections.EMPTY_SET;
    +
       private Map<String,String> tableIdToTableName = null;
       private Map<String,Pattern> poolNameToRegexPattern = null;
       private volatile long lastOOBCheck = System.currentTimeMillis();
       private boolean isIpBasedRegex = false;
       private Map<String,SortedMap<TServerInstance,TabletServerStatus>> pools
= new HashMap<>();
       private int maxTServerMigrations = HOST_BALANCER_REGEX_MAX_MIGRATIONS_DEFAULT;
    +  private int maxOutstandingMigrations = DEFAULT_OUTSTANDING_MIGRATIONS;
    +  private Map<KeyExtent,TabletMigration> migrationsFromLastPass = new HashMap<KeyExtent,TabletMigration>();
    --- End diff --
    
    can these maps be made final?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message