accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivakegg <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Tue, 06 Jun 2017 18:50:21 GMT
Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r120448323
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -565,7 +572,7 @@ private LookupResult lookup(SortedKeyValueIterator<Key,Value>
mmfi, List<Range>
             else
               mmfi.seek(range, LocalityGroupUtil.EMPTY_CF_SET, false);
     
    -        while (mmfi.hasTop()) {
    +        while (!yield.hasYielded() && mmfi.hasTop()) {
    --- End diff --
    
    I think this is a reasonable requirement on the iterator implementation. I will code to
that and add a comment to the hasTop() method in the SKVI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message