accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Sun, 04 Jun 2017 23:14:39 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r120023630
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -746,16 +774,29 @@ Batch nextBatch(SortedKeyValueIterator<Key,Value> iter, Range
range, int num, Se
           iter.next();
         }
     
    -    if (iter.hasTop() == false) {
    -      endOfTabletReached = true;
    -    }
    +    if (yield.hasYielded()) {
    +      continueKey = new Key(yield.getPositionAndReset());
    +      skipContinueKey = true;
    +      if (!range.contains(continueKey)) {
    +        throw new IOException("Underlying iterator yielded to a position outside of its
range: " + continueKey + " not in " + range);
    +      }
     
    -    if (endOfTabletReached) {
    -      continueKey = null;
    -    }
    +      log.debug("Scan yield detected at position " + continueKey);
    --- End diff --
    
    I'd appreciate that. As a suggestion: if there are multiple areas in which you want to
understand the "kinds" of yielding happening: just expose some more metrics. Have a total,
and some specific breakouts of the different lines (i guess initial seek and next calls you're
trying to differentiate?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message