accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ivakegg <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Sat, 03 Jun 2017 18:49:14 GMT
Github user ivakegg commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r119992401
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -746,16 +774,29 @@ Batch nextBatch(SortedKeyValueIterator<Key,Value> iter, Range
range, int num, Se
           iter.next();
         }
     
    -    if (iter.hasTop() == false) {
    -      endOfTabletReached = true;
    -    }
    +    if (yield.hasYielded()) {
    +      continueKey = new Key(yield.getPositionAndReset());
    +      skipContinueKey = true;
    +      if (!range.contains(continueKey)) {
    +        throw new IOException("Underlying iterator yielded to a position outside of its
range: " + continueKey + " not in " + range);
    +      }
     
    -    if (endOfTabletReached) {
    -      continueKey = null;
    -    }
    +      log.debug("Scan yield detected at position " + continueKey);
    --- End diff --
    
    Not sure I agree.  Yielding should be a relatively infrequent occurence.  I, as an operator,
want to know whether this has been happening on a tserver or not.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message