accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Fri, 02 Jun 2017 16:35:44 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r119895044
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/system/SourceSwitchingIterator.java
---
    @@ -126,14 +142,23 @@ public void next() throws IOException {
     
       private void readNext(boolean initialSeek) throws IOException {
     
    +    // we need to check here if we were yielded in case the source was switched out and
re-seeked by someone else (minor compaction/InMemoryMap)
    +    boolean yielded = (yield.isPresent() && yield.get().hasYielded());
    --- End diff --
    
    nit: parens are unnecessary


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message