accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Thu, 01 Jun 2017 18:24:01 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r119692389
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -586,6 +591,11 @@ private LookupResult lookup(SortedKeyValueIterator<Key,Value>
mmfi, List<Range>
               mmfi.next();
             }
     
    +        if (yield.hasYielded()) {
    +          Key yieldPosition = yield.getPositionAndReset();
    --- End diff --
    
    We should probably ensure that an iterator is not returning the same yield key. Suggest
ensuring that the yieldPosition is within the scan range.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message