Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: joshelser <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-260-accumulo@git.apache.org>
In-Reply-To: <git-pr-260-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Content-Type: text/plain
Message-Id: <20170525194805.91ABDDF9A0@git1-us-west.apache.org>
Date: Thu, 25 May 2017 19:48:05 +0000 (UTC)
archived-at: Thu, 25 May 2017 19:48:10 -0000

Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r118568041
  
    --- Diff: test/src/main/java/org/apache/accumulo/test/YieldScannersIT.java ---
    @@ -0,0 +1,71 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.test;
    +
    +import com.google.common.collect.Iterators;
    +import org.apache.accumulo.core.client.Connector;
    +import org.apache.accumulo.core.client.IteratorSetting;
    +import org.apache.accumulo.core.client.Scanner;
    +import org.apache.accumulo.core.data.Key;
    +import org.apache.accumulo.core.data.Value;
    +import org.apache.accumulo.core.security.Authorizations;
    +import org.apache.accumulo.harness.AccumuloClusterHarness;
    +import org.apache.accumulo.minicluster.impl.MiniAccumuloConfigImpl;
    +import org.apache.accumulo.test.functional.YieldingIterator;
    +import org.apache.hadoop.conf.Configuration;
    +import org.junit.Assert;
    +import org.junit.Test;
    +
    +import java.util.Iterator;
    +import java.util.Map;
    +
    +// ACCUMULO-4643
    +public class YieldScannersIT extends AccumuloClusterHarness {
    +
    +  @Override
    +  public int defaultTimeoutSeconds() {
    +    return 600000;
    +  }
    +
    +  @Override
    +  public void configureMiniCluster(MiniAccumuloConfigImpl cfg, Configuration hadoopCoreSite) {
    +    cfg.setNumTservers(1);
    +  }
    +
    +  @Test
    +  public void test() throws Exception {
    +    // make a table
    +    final String tableName = getUniqueNames(1)[0];
    +    final Connector conn = getConnector();
    +    conn.tableOperations().create(tableName);
    +
    +    // make a scanner for a table with 10 keys
    +    final Scanner scanner = conn.createScanner(tableName, Authorizations.EMPTY);
    +    final IteratorSetting cfg = new IteratorSetting(100, YieldingIterator.class);
    +    cfg.addOption(YieldingIterator.NUMBER_OF_KEYS, "10");
    --- End diff --
    
    What about just writing 10 entries to the table and then using your iterator to read them all.
    
    IIUC, the client should see no difference with this change in place (just the number of RPCs changes).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---