Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-256-accumulo@git.apache.org>
In-Reply-To: <git-pr-256-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implementation c...
Content-Type: text/plain
Message-Id: <20170512191356.2DBA0DFD43@git1-us-west.apache.org>
Date: Fri, 12 May 2017 19:13:56 +0000 (UTC)
archived-at: Fri, 12 May 2017 19:13:58 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r116305014
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServerResourceManager.java ---
    @@ -169,25 +170,23 @@ public TabletServerResourceManager(TabletServer tserver, VolumeManager fs) {
         long maxMemory = acuConf.getAsBytes(Property.TSERV_MAXMEM);
         boolean usingNativeMap = acuConf.getBoolean(Property.TSERV_NATIVEMAP_ENABLED) && NativeMap.isLoaded();
     
    -    long blockSize = acuConf.getAsBytes(Property.TSERV_DEFAULT_BLOCKSIZE);
         long dCacheSize = acuConf.getAsBytes(Property.TSERV_DATACACHE_SIZE);
    --- End diff --
    
    A better method name would be `getMaxHeapUsage()`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---