Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: mjwall <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-256-accumulo@git.apache.org>
In-Reply-To: <git-pr-256-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implementation c...
Content-Type: text/plain
Message-Id: <20170512160151.49956DFD43@git1-us-west.apache.org>
Date: Fri, 12 May 2017 16:01:51 +0000 (UTC)
archived-at: Fri, 12 May 2017 16:01:53 -0000

Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r116265855
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheManager.java ---
    @@ -0,0 +1,101 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.file.blockfile.cache;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +import org.apache.accumulo.core.conf.AccumuloConfiguration;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.start.classloader.vfs.AccumuloVFSClassLoader;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +public abstract class BlockCacheManager {
    +
    +  public static final String CACHE_PROPERTY_BASE = Property.GENERAL_ARBITRARY_PROP_PREFIX + "cache.block.";
    +
    +  private static final Logger LOG = LoggerFactory.getLogger(BlockCacheManager.class);
    +  private static BlockCacheManager factory = null;
    +
    +  private final Map<CacheType,BlockCache> caches = new HashMap<>();
    +
    +  /**
    +   * Initialize the caches for each CacheType based on the configuration
    +   * 
    +   * @param conf
    +   *          accumulo configuration
    +   */
    +  public void start(AccumuloConfiguration conf) {
    +    for (CacheType type : CacheType.values()) {
    +      BlockCache cache = this.createCache(conf, type);
    +      this.caches.put(type, cache);
    +    }
    +  }
    +
    +  /**
    +   * Stop caches and release resources
    +   */
    +  public void stop() {}
    --- End diff --
    
    Would it make sense to add something this.caches.clear() to the stop ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---