Mailing-List: contact dev-help@accumulo.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@accumulo.apache.org
From: keith-turner <git@git.apache.org>
To: dev@accumulo.apache.org
Reply-To: dev@accumulo.apache.org
References: <git-pr-256-accumulo@git.apache.org>
In-Reply-To: <git-pr-256-accumulo@git.apache.org>
Subject: [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implentation con...
Content-Type: text/plain
Message-Id: <20170508205104.3C1CFDFD70@git1-us-west.apache.org>
Date: Mon,  8 May 2017 20:51:04 +0000 (UTC)
archived-at: Mon, 08 May 2017 20:51:06 -0000

Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r115347395
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCacheFactory.java ---
    @@ -0,0 +1,33 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.file.blockfile.cache;
    +
    +import org.apache.accumulo.core.conf.AccumuloConfiguration;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.start.classloader.vfs.AccumuloVFSClassLoader;
    +
    +public abstract class BlockCacheFactory {
    +
    +  public static BlockCacheFactory getBlockCacheFactory(AccumuloConfiguration conf) throws Exception {
    +    String impl = conf.get(Property.TSERV_CACHE_IMPL);
    +    Class<? extends BlockCacheFactory> clazz = AccumuloVFSClassLoader.loadClass(impl, BlockCacheFactory.class);
    +    return clazz.newInstance();
    +  }
    +
    +  public abstract BlockCache getBlockCache(AccumuloConfiguration conf);
    --- End diff --
    
    This method could have java with `@see BlockCacheConfiguration a helper class for configuring cache instances`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---