accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dlmarion <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Wed, 31 May 2017 19:54:47 GMT
Github user dlmarion commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r119457222
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/SortedKeyValueIterator.java
---
    @@ -147,4 +147,35 @@
        *              if not supported.
        */
       SortedKeyValueIterator<K,V> deepCopy(IteratorEnvironment env);
    +
    +  /**
    +   * Called when the client (i.e. calling iterator or the tserver) will support this
iterators ability to yield. If called (and true is returned), then when
    +   * next or seek is called this iterator may yield before finding the next top value
and key. When this happens, the yield position (returned by
    +   * getYieldPosition) will be used when this iterator is rebuilt to seek to the position
at which it yielded. This iterator can only yield if the user of this
    +   * iterator has called this method. Note that setYieldSupported will never be called
in row isolation mode.
    +   *
    +   * @return <tt>boolean</tt> True if this iterator supported yielding, false
otherwise.
    +   */
    +  default boolean setYieldSupported() {
    --- End diff --
    
    suggest having a getter and setter instead of using setYieldSupported as both a setter
and getter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message