accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Tue, 30 May 2017 16:03:44 GMT
Github user joshelser commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/iterators/user/
    @@ -0,0 +1,35 @@
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.iterators.user;
    + * This exception can be thrown at from a next or seek call on an iterator to allow other
scans to get time slots. This mechanism is intended to avoid a set of
    + * scans to dominate all of the scan slots (readahead threads) and starve other scans
    + */
    +public class ScanYieldException extends RuntimeException {
    +  private final Key position;
    +  public ScanYieldException(Key position) {
    --- End diff --
    > It appears that I have not adequately described the process here. Here is a scenario
that might help understanding:
    No, I think I understand the control flow. I'm more worried about how we pass along this
"tribal knowledge" to developers who stumble onto this Exception/code-path. As we try to make
SKVI more "user-friendly", I'm trying to make sure that new things which are added stand up
to the level of "ready for users" and don't increase our complexity-debt :)

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message