accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #260: ACCUMULO-4643 initial implementation
Date Thu, 25 May 2017 19:48:05 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/260#discussion_r118567242
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
---
    @@ -548,11 +549,13 @@ private LookupResult lookup(SortedKeyValueIterator<Key,Value>
mmfi, List<Range>
           batchTimeOut = 0;
         }
     
    +    boolean yield = false;
    +
         for (Range range : ranges) {
     
           boolean timesUp = batchTimeOut > 0 && System.nanoTime() > returnTime;
     
    -      if (exceededMemoryUsage || tabletClosed || timesUp) {
    +      if (exceededMemoryUsage || tabletClosed || timesUp || yield) {
             lookupResult.unfinishedRanges.add(range);
             continue;
    --- End diff --
    
    The way the Exception's javadoc reads, it would preempty the entire Scan RPC, but it's
actually just pre-empting one Range. Is that intentional?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message