accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <...@git.apache.org>
Subject [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implementation c...
Date Thu, 11 May 2017 17:57:33 GMT
Github user mjwall commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r116044162
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/CachedBlock.java
---
    @@ -19,6 +19,8 @@
     
     import java.util.Objects;
     
    +import org.apache.accumulo.core.file.blockfile.cache.lru.LruBlockCache;
    +
    --- End diff --
    
    Seems like CachedBlock is only used in LruBlockCache.  Consider renaming to LruCachedBlock
or CachedLruBlock


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message