accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mjwall <>
Subject [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implementation c...
Date Thu, 11 May 2017 17:57:33 GMT
Github user mjwall commented on a diff in the pull request:
    --- Diff: core/src/main/java/org/apache/accumulo/core/conf/ ---
    @@ -95,4 +95,16 @@ public void set(String key, String value) {
         copy.put(key, value);
    +  /**
    +   * Sets a property in this configuration if it is not already defined.
    +   * 
    +   * @param key
    +   *          key of property to set
    +   * @param value
    +   *          property value
    +   */
    +  public void setIfAbsent(String key, String value) {
    --- End diff --
    This seems to only be used in BlockCacheConfigurationHelper, whose setIfAbsent method
is only used in TestLRUBlockCache.  Why would you want this functionality?
    Maybe it could log at debug if the key was present and therefore not set.  Seems like
an opportunity for confusion.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message