accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implentation con...
Date Mon, 08 May 2017 21:38:43 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r115359875
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/lru/LruBlockCacheConfiguration.java
---
    @@ -0,0 +1,122 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +package org.apache.accumulo.core.file.blockfile.cache.lru;
    +
    +import java.util.Map;
    +
    +import org.apache.accumulo.core.conf.AccumuloConfiguration;
    +import org.apache.accumulo.core.conf.Property;
    +import org.apache.accumulo.core.file.blockfile.cache.BlockCacheConfiguration;
    +
    +public final class LruBlockCacheConfiguration extends BlockCacheConfiguration {
    +
    +  /** Default Configuration Parameters */
    +
    +  /** Backing Concurrent Map Configuration */
    +  public static final Float DEFAULT_LOAD_FACTOR = 0.75f;
    +  public static final Integer DEFAULT_CONCURRENCY_LEVEL = 16;
    +
    +  /** Eviction thresholds */
    +  public static final Float DEFAULT_MIN_FACTOR = 0.75f;
    +  public static final Float DEFAULT_ACCEPTABLE_FACTOR = 0.85f;
    +
    +  /** Priority buckets */
    +  public static final Float DEFAULT_SINGLE_FACTOR = 0.25f;
    +  public static final Float DEFAULT_MULTI_FACTOR = 0.50f;
    +  public static final Float DEFAULT_MEMORY_FACTOR = 0.25f;
    +
    +  // property names
    +  private static final String PREFIX = Property.GENERAL_ARBITRARY_PROP_PREFIX + "cache.block.lru.";
    --- End diff --
    
    The `getOrDefault(CacheType ct, String key, T default)` method could fall back to calling
`getOrDefault(String key, T default)` in the case where nothing is set for the specific cache
type.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message