accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From joshelser <...@git.apache.org>
Subject [GitHub] accumulo pull request #256: ACCUMULO-4463: Make block cache implentation con...
Date Mon, 08 May 2017 16:05:15 GMT
Github user joshelser commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/256#discussion_r115286028
  
    --- Diff: core/src/main/java/org/apache/accumulo/core/file/blockfile/cache/BlockCache.java
---
    @@ -17,10 +17,30 @@
      */
     package org.apache.accumulo.core.file.blockfile.cache;
     
    +import org.apache.accumulo.core.conf.AccumuloConfiguration;
    +
     /**
      * Block cache interface.
      */
     public interface BlockCache {
    +
    +  /**
    +   * Start the block cache
    +   *
    +   * @param conf
    +   *          Accumulo configuration object
    +   * @param maxSize
    +   *          maximum size of the on-heap cache
    +   * @param blockSize
    +   *          size of the default RFile blocks
    +   */
    +  void start(AccumuloConfiguration conf, long maxSize, long blockSize) throws Exception;
    --- End diff --
    
    Also, we could separate the configuration and start logic into separate methods.
    
    Unrelated thought: what about creating a POJO to encapsulate this information. It would
prevent drift in the configuration details from breaking blockcache impls (e.g. BlockCacheConfiguration,
presently made up of an AccuConf, maxSize, and blockSize).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message