accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...
Date Wed, 03 May 2017 16:40:37 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/254#discussion_r114593667
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
    @@ -536,8 +570,21 @@ public ReplicationStats execute(Client client) throws Exception {
     
           // If we have some edits to send
           if (0 < edits.walEdits.getEditsSize()) {
    +        // Check if we are interrupted before to writing the edits
    +        if (Thread.interrupted()) {
    +          log.debug("Replication work interrupted before writing edits, returning empty
replication stats");
    +          return new ReplicationStats(0L, 0L, 0L);
    +        }
    +
             log.debug("Sending {} edits", edits.walEdits.getEditsSize());
             long entriesReplicated = client.replicateLog(remoteTableId, edits.walEdits, tcreds);
    --- End diff --
    
    > I don't see a difference either way.
    
    If the thread interruption properly percolates up from the thrift call, then it does seem
functionally equivalent.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message