accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From adamjshook <>
Subject [GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...
Date Wed, 03 May 2017 15:27:19 GMT
Github user adamjshook commented on a diff in the pull request:
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/
    @@ -536,8 +570,21 @@ public ReplicationStats execute(Client client) throws Exception {
           // If we have some edits to send
           if (0 < edits.walEdits.getEditsSize()) {
    +        // Check if we are interrupted before to writing the edits
    +        if (Thread.interrupted()) {
    +          log.debug("Replication work interrupted before writing edits, returning empty
replication stats");
    +          return new ReplicationStats(0L, 0L, 0L);
    +        }
             log.debug("Sending {} edits", edits.walEdits.getEditsSize());
             long entriesReplicated = client.replicateLog(remoteTableId, edits.walEdits, tcreds);
    --- End diff --
    Not sure how to go about setting the client's timeout -- not seeing anything in the API
directly.  Digging in a bit I see that `ReplicationClient#getServicerConnection` is using
`ThriftUtil#getClientNoTimeout`?  Maybe that is all that needs to change and this entire thing
is moot.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

View raw message