accumulo-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From keith-turner <...@git.apache.org>
Subject [GitHub] accumulo pull request #254: [ACCUMULO-4506] Add a timeout to the replication...
Date Wed, 03 May 2017 15:26:40 GMT
Github user keith-turner commented on a diff in the pull request:

    https://github.com/apache/accumulo/pull/254#discussion_r114575274
  
    --- Diff: server/tserver/src/main/java/org/apache/accumulo/tserver/replication/AccumuloReplicaSystem.java
---
    @@ -362,6 +400,7 @@ protected Status replicateRFiles(ClientContext peerContext, final
HostAndPort pe
       protected Status replicateLogs(ClientContext peerContext, final HostAndPort peerTserver,
final ReplicationTarget target, final Path p, final Status status,
           final long sizeLimit, final String remoteTableId, final TCredentials tcreds, final
ReplicaSystemHelper helper, final UserGroupInformation accumuloUgi)
           throws TTransportException, AccumuloException, AccumuloSecurityException {
    +    stopReplication.set(false);
    --- End diff --
    
    Is it possible for multiple threads to call this method concurrently?  If so, may want
to make stopReplication a local var so that each thread gets its own atomic boolean.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message